chore: update gulpfile.js scripts to use ESM, bump plugin versions #9420
Conversation
web-padawan
force-pushed
the
chore/gulpfile-esm
branch
2 times, most recently
from
a65c551 to
5af8e69
Compare
| import * as cheerio from 'cheerio'; | ||
| import { dest, src, task } from 'gulp'; | ||
| import concat from 'gulp-concat'; | ||
| import { gulpPlugin } from 'gulp-plugin-extras'; |
There was a problem hiding this comment.
Replaced usage of gulp-modify which pulls in deprecated gulp-util in this file with custom plugins.
| import fs from 'fs'; | ||
| import { dest, src, task } from 'gulp'; | ||
| import iconfont from 'gulp-iconfont'; | ||
| import imagemin, { svgo } from 'gulp-imagemin'; |
There was a problem hiding this comment.
Replaced gulp-svgmin which is outdated with gulp-imagemin using a newer version of svgo.
There was a problem hiding this comment.
BTW, by default svgo does nothing and says that files are already optimized. But maybe we can still keep it.
There was a problem hiding this comment.
UPD: changed to use imagemin-svgo directly with version 10 for now to not install other imagemin plugins.
There is a newer version 11 which depends on svgo v3 that has some breaking changes.
|
UPD: for some reason screenshot with font icons has height changes, icons now have |
web-padawan
force-pushed
the
chore/gulpfile-esm
branch
from
f9cc9a8 to
47519d2
Compare
|
Tried to revert changes in fontello/svg2ttf@de2563a and fontello/svg2ttf@ba4d551, let's see if it helps. |
web-padawan
force-pushed
the
chore/gulpfile-esm
branch
from
47519d2 to
9728db8
Compare
web-padawan
force-pushed
the
chore/gulpfile-esm
branch
from
a6f3311 to
eb89bf9
Compare
|
Description
This should resolve some dependabot alerts about outdated dependencies versions.
Tested on Windows and the script produces identical output for all 3 packages.
Note: also updated
gulp-clito recently released 3.1.0 to fix errors on top-level awaits.Type of change
Note
Some changes in
svg2ttfcaused the icons to have incorrect line-height on Windows - 26px instead of 24px.I was able to figure out two changes that are apparently related and applied a patch to revert to old behavior.