Skip to content
This repository has been archived by the owner on Nov 3, 2024. It is now read-only.

EntityFramework Storage implementation (draft) #60

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

EntityFramework Storage implementation (draft) #60

wants to merge 36 commits into from

Conversation

semack
Copy link

@semack semack commented Dec 4, 2020

Hi @valdisiljuconoks,

This pull-request related to #59 includes:

  1. Added ServiceLocator anti-pattern to the DbLocalizationProvider.AspNetCore implementation. It temporary there and can be removed after the redesign of TypeFactory to support DI.
  2. Implemented DbLocalizationProvider.AspNetCore.EntityFramewrok storage library.
  3. Modified AspNetCore example to use a new storage library.
  4. Changed product version to 6.4.0.
  5. Updated README.md

It needs to be tested now. Unfortunately, hadn't enough time for it. Will do on this weekend if get luck.

Please review. Any suggestions are appreciated.

Kind regards,
Andriy

@semack semack changed the title Draft EntityFramework Storage implemtation Draft EntityFramework Storage implementation Dec 4, 2020
@semack semack changed the title Draft EntityFramework Storage implementation EntityFramework Storage implementation (draft) Dec 4, 2020
@valdisiljuconoks
Copy link
Owner

Awesome! However v7 (next major) version is already in workings ;) I have few local branches across all submodules where I was experiencing with new features.

I'm gonna pull over some of the features from this PR this add EF option for v7. Merge everything as-is would be too much hustle as things have changed.

@semack
Copy link
Author

semack commented Dec 5, 2020

Ok, my goal to start using your lib in my project ASAP ;)
The main change is adding ServiceLocator and its registration. The EF lib I've added is standalone, so it doesn't need any global modifications. Waiting for v7 ;)

@valdisiljuconoks
Copy link
Owner

Could you elaborate on service locator necessity? As in next major version I'm going to or at least I'm planning to throw out all the statics. It's been too much trouble in unit tests and concurrent things and all around

@valdisiljuconoks
Copy link
Owner

Anything particular you were missing from the library that should be supported out of the box?

@semack
Copy link
Author

semack commented Dec 5, 2020

Could you elaborate on service locator necessity? As in next major version I'm going to or at least I'm planning to throw out all the statics. It's been too much trouble in unit tests and concurrent things and all around

It needs there to get an instance of DbContext registered in the application. After making lib the DI compatible, it could be injected by handler's or repository's constructor automatically in a classical way.

BTW, You could find my comments in TODOs I've added.

@semack
Copy link
Author

semack commented Dec 7, 2020

Do you have any updates?

@valdisiljuconoks
Copy link
Owner

I've been crazy busy with my primary responsibilities, so I'm delaying behind here.

Working on v7 is in progress, but it has quite big scope therefore it might not come as quick as we would like to.

I'll see ar some point how to merge EF. Just need to block time for this.

@valdisiljuconoks valdisiljuconoks self-requested a review December 21, 2020 12:36
@valdisiljuconoks valdisiljuconoks added the enhancement New feature or request label Dec 21, 2020
@valdisiljuconoks valdisiljuconoks added this to the 6.4 milestone Dec 21, 2020
@valdisiljuconoks
Copy link
Owner

Hey @semack

Could you please merge conflicts before we proceed here? Not sure why, but your repo shown as "unknown" from my perspective. Do you know reason?

image

@semack
Copy link
Author

semack commented Dec 22, 2020

Could you please merge conflicts before we proceed here? Not sure why, but your repo shown as "unknown" from my perspective. Do you know reason?

Unfortunately, I've deleted my fork. Anyways, I guess you could do the review by yourself, nothing special has been changed.

@valdisiljuconoks valdisiljuconoks modified the milestones: 6.4, 7.0 Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants