-
-
Notifications
You must be signed in to change notification settings - Fork 21
EntityFramework Storage implementation (draft) #60
base: master
Are you sure you want to change the base?
Conversation
Awesome! However v7 (next major) version is already in workings ;) I have few local branches across all submodules where I was experiencing with new features. I'm gonna pull over some of the features from this PR this add EF option for v7. Merge everything as-is would be too much hustle as things have changed. |
Ok, my goal to start using your lib in my project ASAP ;) |
Could you elaborate on service locator necessity? As in next major version I'm going to or at least I'm planning to throw out all the statics. It's been too much trouble in unit tests and concurrent things and all around |
Anything particular you were missing from the library that should be supported out of the box? |
It needs there to get an instance of DbContext registered in the application. After making lib the DI compatible, it could be injected by handler's or repository's constructor automatically in a classical way. BTW, You could find my comments in TODOs I've added. |
Do you have any updates? |
1. Sync on start 2. DbContext LifeTime
I've been crazy busy with my primary responsibilities, so I'm delaying behind here. Working on v7 is in progress, but it has quite big scope therefore it might not come as quick as we would like to. I'll see ar some point how to merge EF. Just need to block time for this. |
Hey @semack Could you please merge conflicts before we proceed here? Not sure why, but your repo shown as "unknown" from my perspective. Do you know reason? |
Unfortunately, I've deleted my fork. Anyways, I guess you could do the review by yourself, nothing special has been changed. |
Hi @valdisiljuconoks,
This pull-request related to #59 includes:
It needs to be tested now. Unfortunately, hadn't enough time for it. Will do on this weekend if get luck.
Please review. Any suggestions are appreciated.
Kind regards,
Andriy