Pep8 linting #107
Open
Pep8 linting #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ledm thanks to you we now have a "standards" label, although am a bit scared to look at this PR just yet 🤣 |
|
@ledm this is starting to become stale, mate. You reckon we can just power on sometime and get it over the finish line? I can help with it since I have to yapf a whole lot of code for the ANCIL project too |
Conflicts: bgcval2/analysis_compare.py
ledm
commented
Nov 7, 2023
| @@ -1635,34 +1697,8 @@ def newImageLocation(fn): | |||
| print("Adding ", relfn, "to script") | |||
|
|
|||
| if len(otherFilenames): | |||
| # I think this is never happens anymore. | |||
| # This should never happens. | |||
| assert 0 | |||
There was a problem hiding this comment.
Suggested change
| assert 0 | |
| print('Report: otherFilenames is too long:', otherFilenames ) | |
| raise IndexError |
|
I think the tests are currently failing because they reference some of the objects that were renamed in this PR. I'll see what I can do. Edit. nope, jsut me being stupid. |
|
nice! Then you reckon is close to merge? I can plop a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran a linter, and a few refactors over bgcval2.
Code should be cleaner and more readable, but a lot of changes to review.
Happy to do it in stages.
Closes #106