Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving interface and help comments in single job analysis. #37

Open
4 tasks
ledm opened this issue Aug 9, 2022 · 2 comments
Open
4 tasks

Improving interface and help comments in single job analysis. #37

ledm opened this issue Aug 9, 2022 · 2 comments

Comments

@ledm
Copy link
Collaborator

ledm commented Aug 9, 2022

These jobs got bumped out of PR #34 :

  • bgcval2_make_report.py
  • bgcval_p2p.py
  • bgcval.py (this used to be the whole package, but it needs to be framed in a clearer way.)
  • Fix hard wired paths in download_from_mass.findLastFinishedYear

I'm going to be working on them in https://github.com/valeriupredoi/bgcval2/tree/improve_help_messages_singlejob, which is based on the branch in pr 34.

@valeriupredoi
Copy link
Owner

Excellent! can you merge main now in that branch pls? And open a PR asap so we don't start having ghost branches 😁 Also, we should now concern with tests as well - I have test_command_line.py now, so we'll have to add executables and tests for them there too, we're big boys now, with tests 😆

@ledm
Copy link
Collaborator Author

ledm commented Aug 9, 2022

Good one. Already merged. I'm leaving tests up to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants