feat(isAlpha, isAlphanumeric): added support for Irish fadas (accents)#2281
Open
khoait wants to merge 87 commits intovalidatorjs:masterfrom
Open
feat(isAlpha, isAlphanumeric): added support for Irish fadas (accents)#2281khoait wants to merge 87 commits intovalidatorjs:masterfrom
khoait wants to merge 87 commits intovalidatorjs:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2281 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 107 107
Lines 2454 2454
Branches 619 619
=======================================
Hits 2453 2453
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* chore: add additional testcases to isMailtoURI Line 44 is only partially covered before this change * chore: add additonal const to figure out which part is partial * chore: add testcase for single ? * chore: add another line to find partial coverage * chore: remove default to * chore: combine consts again
Co-authored-by: Musa <goat_musa@Musas-MBP.cust.communityfibre.co.uk>
* Update isPassportNumber.js Added the updated Azerbaijan passport validation: See issue: validatorjs#2274 * Update validators.test.js
…#2285) * Add Esperanto to alpha.js * Add Esperanto (eo) to README.md * Add tests for Esperanto validation * Fix tests * Update Esperanto tests
* Pakistan vehicles license plate support * Readme and test cases updated * Update README.md
Added isAbaRouting validator, new validator. Check whether a string is ABA routing number for US bank account & cheque ref: https://en.wikipedia.org/wiki/ABA_routing_transit_number
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
* chore: Publish to NPM with provenance The release process in this repository is already automated via GitHub Actions, which is a great first step toward creating trust in the supply chain. Recently, NPM has started to support publishing with the `--provenance` flag. This flag creates a link between the GitHub Actions run that created the release and the final artifact on NPM. This linkage further ensures that package installs can be traced back to a specific code revision. For more information on publishing with provenance, please refer to: https://github.blog/2023-04-19-introducing-npm-package-provenance/ * chore: Use Node.js 18 for publishing to support provenance
* Modified symbolRegex in isStrongPassword to include '\' * Modify test to check validity of strong password with \ character
* fix(isVAT): fixed KZ VAT number length check * fix(isVAT): fixed KZ VAT number length test
Co-authored-by: vfarylevych <vfarylevych@primocollect.com.ua>
…y codes (validatorjs#2399) * Create isISO31661Numeric.js * Add tests for ISO 3166-1 numeric country codes * Describe isISO31661Numeric in README.md * Add isISO31661Numeric to index.js
…atorjs#2406) * feat(isBtcAddress): ✨ Add support for all address formats and testnets * replace original tests file * add new regex test cases * Add missing closure * fix weird double quote issue
…idatorjs#2494) * enhance isEmail to have regexp for host_whitelist * update README.md * refactor code * update test name * fix code logic for checkHost --------- Co-authored-by: Rubin Bhandari <roobin.bhandari@gmail.com>
…er (validatorjs#2500) * feat: Validation for macedonian phone number added * fix:refined regex for all mk numbers
* feat: isISO15924 * test: isISO15924 * docs: add isISO15924 to README * refactor(isISO15924): update data sources * refactor(isISO15924): update data source reference * chore: fix linting
* refactor: allow for splitting tests to different files * feat(isAfter): allow usage of options object * style: make options italic * refactor: rename test file extension to .test.js * refactor: rename test-functions to testFunctions * refactor: implement suggestion from validatorjs#2019 review * refactor: remove custom repeat to use native function * refactor: implement suggestion new Date * Refactor isIP with options API * Move and fix tests * Add more tests * Fix README * Fix broken isIPRange * refactor: change test files to prepare for validatorjs#1874 * Maintain legacy syntax * Revert "Fix broken isIPRange" This reverts commit cf9ebc7. * Improve naming * Fix comment text * Reinstate test for isAlpha --------- Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
- Regex now covers both of the following patterns: - Old pattern of: 2 letters, followed by 6 digits - New pattern of: 1 letter, 6 digits, 2 letters
add padding to the option list update regexes to support validation with/without padding update default options to keep the changes backward compatible add new test to cover different scenarios
Co-authored-by: rajput-balram <balrams@nurseio.com> Co-authored-by: Rubin Bhandari <roobin.bhandari@gmail.com>
* refactor: allow for splitting tests to different files * feat(isAfter): allow usage of options object * style: make options italic * refactor: rename test file extension to .test.js * refactor: rename test-functions to testFunctions * refactor: implement suggestion from validatorjs#2019 review * refactor: remove custom repeat to use native function * refactor: implement suggestion new Date * Refactor isBefore with options API * Refactor isBefore tests * Refactor to simplify logic * Update README * Refactor logic * Improve README formatting * Fix backwards-compat * Remove redundant string assertion * Fix comment * Reinstate legacy tests * Change arg name according to code review * Add line break according to code review * Revert change of simplifying toDate * Fix whitespace issues * Fix test * Fix tests * Format file for consistency with isBefore * Remove redundant file * Remove old tests * Add tests for undefined args * Remove arguments: linter error * Improve comment * Use recommended variable name * Improve readme text according to code review * Make isAfter arguments more robust * Split test cases into given and default end date --------- Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
* 🐛 fix: Cyprus mobile phone validation * 🧪 chore: update unit tests
…datorjs#2372) * refactor: Refactor assertString * refactor: Refactor assertString with unit tests * add: Empty string unit test * add: Null input value and more tests * fix: Sentence correction
* fix validatorjs#2039 * remove line and add test to isIp.test.js * change isIp --------- Co-authored-by: shreysinha25 <shrey.sinha@skyvoyage.in> Co-authored-by: Rubin Bhandari <roobin.bhandari@gmail.com>
WikiRik
previously approved these changes
Mar 28, 2025
Member
WikiRik
left a comment
WikiRik
left a comment
There was a problem hiding this comment.
Looks good, please fix the merge conflict
WikiRik
added
mc-to-land
rubiin
previously approved these changes
Mar 29, 2025
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Irish fadas reference:
https://en.wikipedia.org/wiki/Irish_orthography#Vowels
Checklist