fix(isRgbColor): allow more than one decimal on alpha#2378
Closed
marcopixel wants to merge 1 commit intovalidatorjs:masterfrom
marcopixel:master
Closed
fix(isRgbColor): allow more than one decimal on alpha#2378marcopixel wants to merge 1 commit intovalidatorjs:masterfrom marcopixel:master
marcopixel wants to merge 1 commit intovalidatorjs:masterfrom
marcopixel:master
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2378 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 107 107
Lines 2449 2449
Branches 619 619
=========================================
Hits 2449 2449 ☔ View full report in Codecov by Sentry. |
Author
|
Sorry, i've just noticed that this is a duplicate of #2346 - the difference between these two pull requests is that mine doesn't limit to a second decimal point. |
Member
|
Let's discuss that difference in #2346 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current regex is only allowing for one decimal on the alpha value even though the specification has no limit on maximal decimals.
I've adjusted the regex + the tests accordingly and it does pass now if it has more than one decimal if set as number between 1 and 0.
References
https://www.w3.org/TR/css-color-3/#transparency
https://www.w3.org/TR/2011/REC-CSS2-20110607/syndata.html#value-def-number
Checklist