fixes #2430 - scientific notation support#2488
Open
OlaOluwalekan wants to merge 1 commit intovalidatorjs:masterfrom
Open
fixes #2430 - scientific notation support#2488OlaOluwalekan wants to merge 1 commit intovalidatorjs:masterfrom
OlaOluwalekan wants to merge 1 commit intovalidatorjs:masterfrom
Conversation
WikiRik
requested changes
Mar 27, 2025
Member
WikiRik
left a comment
WikiRik
left a comment
There was a problem hiding this comment.
Please undo your own formatter changes and add tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes isNumeric Validator
I have updated the isNumeric function in "src/lib/isNumeric.js". I have included a more robust regex to handle large numbers solving the error associated with the scientific notation.
File changed
Checklist