Open
Conversation
rubiin
previously approved these changes
Mar 29, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2541 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 113 113
Lines 2527 2527
Branches 641 641
=======================================
Hits 2526 2526
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cb7c183 to
b564f40
Compare
Member
Author
|
Had to fix merge conflicts in regards to the recently merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like in #2159 this PR splits tests of validators to their separate files. Based on #2159 (review) this PR tackles validators that have > 100 loc. Only
isMobilePhonewas not done here because of the 50+ open PRs for it.I also ran prettier on the split test files so there are some styling changes.
Checklist