Add ~490 IPv6 test cases with test/manyV6.test.ts#2602
Closed
richb-hanover wants to merge 1 commit intovalidatorjs:masterfrom
richb-hanover:add-many-tests
Closed
Add ~490 IPv6 test cases with test/manyV6.test.ts#2602richb-hanover wants to merge 1 commit intovalidatorjs:masterfrom richb-hanover:add-many-tests
richb-hanover wants to merge 1 commit intovalidatorjs:masterfrom
richb-hanover:add-many-tests
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2602 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2536 2536
Branches 642 642
=========================================
Hits 2536 2536 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a manyV6.test.js file that includes ~490 test cases for IPV6 addresses.
A long time ago (2013), my company added IPv6 to our networking product. We produced a whole suite of test cases to check our IPv6 validation code. You can review the original at: https://github.com/richb-intermapper/IPv6-Regex/blob/master/test-ipv6-regex.pl
This PR translates the original perl code to Javascript. It prints "." for successful tests, and a diagnostic message where it fails.
GOOD NEWS: validator.js succeeds with no changes on all the tests
To run:
The new file sits in test and is called as part of
npm testChecklist