fix(compatibility): add Object.entries polyfill#2604
Closed
fearoff999 wants to merge 3 commits intovalidatorjs:masterfrom
Closed
fix(compatibility): add Object.entries polyfill#2604fearoff999 wants to merge 3 commits intovalidatorjs:masterfrom
fearoff999 wants to merge 3 commits intovalidatorjs:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2604 +/- ##
===========================================
- Coverage 100.00% 99.72% -0.28%
===========================================
Files 114 115 +1
Lines 2536 2544 +8
Branches 642 643 +1
===========================================
+ Hits 2536 2537 +1
- Misses 0 6 +6
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Thanks for trying to solve this issue! I think we need to update the package.json to override the dependency that babel has updated which breaks Node 6 compatibility |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR #2603 checks failed on old versions of nodejs (cause of object.entries not a function)
In this PR polyfill for object.entries was added if doesnt available at current environment