Adding usage of must_obey_client in wrapper to improve performace #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarthikSubbarao
requested changes
Feb 12, 2025
zackcam
force-pushed
the
unstable
branch
2 times, most recently
from
5f86d51 to
ce344e6
Compare
zackcam
force-pushed
the
unstable
branch
8 times, most recently
from
71d22d4 to
97e5bab
Compare
Signed-off-by: zackcam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a wrapper for the ValkeyModule_MustObeyClient function in order to check if commands are from the primary client or AOF client in a more efficient way. If this function does not exist we fall back to checking for replicated flag in the GetContextFlags API as a best effort.
Updating one test to use different specified reserve arguments in order to reduce the amount of items we need to add to fill up the filter which in turn will reduce the run time of the test but will still provide the same testing functionality.