Improving build script to provide more options#69
Closed
zackcam wants to merge 1 commit intovalkey-io:unstablefrom
Closed
Improving build script to provide more options#69zackcam wants to merge 1 commit intovalkey-io:unstablefrom
zackcam wants to merge 1 commit intovalkey-io:unstablefrom
Conversation
| do | ||
| arg="$1" | ||
| case $arg in | ||
| --release) |
Member
There was a problem hiding this comment.
Can we add a flag to skip the clippy checks? valkey-bundle calls this build.sh script so they would want an option to build the bloom binary without any linter / formatting checks since Rust linter updates may occur at a higher frequency than our releases
Member
There was a problem hiding this comment.
The bundle doesn't require this flag anymore, you can still do it if you'd like though
Signed-off-by: zackcam <zackcam@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new help, integration, and unit argument for the build script this will allow developers/users to target specifically what they want to do with building in an easier manner.
This also has been reflected in the README.md with the new arguments and a quick explanation of what they do