Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Address flake8 lint issues #3205

Merged
merged 13 commits into from
Feb 19, 2025
Merged

Python: Address flake8 lint issues #3205

merged 13 commits into from
Feb 19, 2025

Conversation

edlng
Copy link
Contributor

@edlng edlng commented Feb 19, 2025 •
edited
Loading

This PR fixes flake8 lint issues.

Issue link

This Pull Request is linked to issue (URL): #2466

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

edlng and others added 11 commits February 12, 2025 16:24
@edlng
wip fixing lint
99abb2b 
Signed-off-by: Edward Liang <[email protected]>
@edlng
Merge remote-tracking branch 'upstream/main' into python/fix-lint
273ed76
@edlng
Merge remote-tracking branch 'upstream/main' into python/fix-lint
8b56760
@edlng
Merge remote-tracking branch 'upstream/main' into python/fix-lint
652c8ce
@edlng
Fix lint
aeaaf38 
Signed-off-by: Edward Liang <[email protected]>
@edlng
merge fixes
5797505 
Signed-off-by: Edward Liang <[email protected]>
@edlng
pubsub test fix experiment
3f5d483 
Signed-off-by: Edward Liang <[email protected]>
@edlng
remove exit zero
848f470 
Signed-off-by: Edward Liang <[email protected]>
@edlng
fix type checks
5a958c6 
Signed-off-by: Edward Liang <[email protected]>
@edlng
add back accidental deletion in makefile
ee24ca4 
Signed-off-by: Edward Liang <[email protected]>
@edlng
Merge branch 'main' into python/fix-lint
82ac286
@edlng edlng marked this pull request as ready for review February 19, 2025 18:34
@edlng edlng requested a review from a team as a code owner February 19, 2025 18:34
Yury-Fridlyand
Yury-Fridlyand approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Does this linter have auto-fix option? If yes, please refer it in the developer doc.

@Yury-Fridlyand Yury-Fridlyand added the python Python wrapper label Feb 19, 2025
@edlng
fix black lint on ubuntu
0b20021 
Signed-off-by: Edward Liang <[email protected]>
@edlng
Copy link
Contributor Author

edlng commented Feb 19, 2025

Thank you! Does this linter have auto-fix option? If yes, please refer it in the developer doc.

flake8 does not have an auto-fix option unfortunately

jbrinkman
jbrinkman approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@jbrinkman jbrinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yury-Fridlyand Yury-Fridlyand merged commit 7f386f0 into valkey-io:main Feb 19, 2025
27 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the python/fix-lint branch February 19, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrinkman jbrinkman jbrinkman approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

Assignees
No one assigned
Labels
python Python wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edlng @jbrinkman @Yury-Fridlyand