-
Notifications
You must be signed in to change notification settings - Fork 67
Blog post about new hash table #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think the content is really good. Is @SoftlyRaining planning on adding more information about benchmark results?
Signed-off-by: Viktor Söderqvist <[email protected]>
Signed-off-by: Viktor Söderqvist <[email protected]>
Signed-off-by: Viktor Söderqvist <[email protected]>
Signed-off-by: Viktor Söderqvist <[email protected]>
7741e22
to
fccd669
Compare
Signed-off-by: Viktor Söderqvist <[email protected]>
Signed-off-by: Viktor Söderqvist <[email protected]>
Signed-off-by: Viktor Söderqvist <[email protected]>
@rjd15372 Do you want to take a look? |
Signed-off-by: Viktor Söderqvist <[email protected]>
better. The zigzag pattern is because of aliasing between the datapoint spacing | ||
and the memory allocator's discrete allocation sizes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The zigzag pattern is because of aliasing between the datapoint spacing
and the memory allocator's discrete allocation sizes."
I couldn't understand what you mean with this. Can you describe it in another way to make it more clear?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took this from Rain's issue with the diagrams. :)
It's wasted memory when jemalloc allocates more memory than we need. The sizes are as in this table: http://jemalloc.net/jemalloc.3.html#size_classes
Explaining this is probably not worth it. I'll cut it down to this, ok?
The zigzag pattern is because of unused memory resulting from the memory
allocator's discrete allocation sizes.
Signed-off-by: Viktor Söderqvist <[email protected]>
Signed-off-by: Viktor Söderqvist <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pass for grammar, will auto-apply these changes
Signed-off-by: Madelyn Olson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it.
Follow-up of #195 and #227. Signed-off-by: Viktor Söderqvist <[email protected]>
The new new hash table is one of the highlights of the upcoming 8.1 release.