Skip to content

feat: Add GitHub button to navigation bar #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

phiro56
Copy link
Contributor

@phiro56 phiro56 commented Jul 4, 2025

feat: Add GitHub button to navigation bar

Screenshot 2025-07-03 at 10 00 44 PM

Copy link
Member

@stockholmux stockholmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the look but it fails responsiveness between width of 917px and the breakpoint at 768px, so the menu bar gets eaten off the right side (also affects "Try Valkey" item)

Screenshot 2025-07-11 at 7 57 31 AM Screenshot 2025-07-11 at 7 56 14 AM

@phiro56
Copy link
Contributor Author

phiro56 commented Jul 11, 2025

@stockholmux I've increase responsive view port of the main nav to 1024px...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants