Conversation
Signed-off-by: Adam Fowler <adamfowler71@gmail.com>
Signed-off-by: Adam Fowler <adamfowler71@gmail.com>
Signed-off-by: Adam Fowler <adamfowler71@gmail.com>
stockholmux
left a comment
There was a problem hiding this comment.
LGTM. It might could use another set of eyes to refine wording/grammar but otherwise it's good to go.
|
@adam-fowler is the publish date (April 22) specific? There are a few other timeline coordinated blogs coming out around the same window. |
| @@ -0,0 +1,58 @@ | |||
| +++ | |||
| title= "valkey-swift - Announcing 1.0 Release " | |||
| description = "We are now excited to announce the 1.0 release of valkey-swift, a client library for Valkey written in Swift." | |||
There was a problem hiding this comment.
I’d recommend keeping the capitalization consistent—either sentence case or proper case throughout.
There was a problem hiding this comment.
I see it as sentence case for "valkey-swift" yet proper case when alone as "Swift". Not sure if intentional
There was a problem hiding this comment.
valkey-swift is the name of the repo, but Swift the language tends to always get capitalized. See swift.org blog posts
| @@ -0,0 +1,58 @@ | |||
| +++ | |||
| title= "valkey-swift - Announcing 1.0 Release " | |||
| description = "We are now excited to announce the 1.0 release of valkey-swift, a client library for Valkey written in Swift." | |||
There was a problem hiding this comment.
Please see this google doc for edit suggestions https://docs.google.com/document/d/1EV_QsQtofFOdmAK7IhX2x-k6ZgdrHaXickDs1w4Gb30/edit?tab=t.0
There was a problem hiding this comment.
Thanks for this @crystalphamLF I've introduced most of your suggestions
No date is set. I just needed to define some date to get this PR up |
Signed-off-by: Adam Fowler <adamfowler71@gmail.com>
Signed-off-by: Adam Fowler <adamfowler71@gmail.com>
0520f9b to
31787be
Compare
Signed-off-by: Adam Fowler <adamfowler71@gmail.com>
heckj
left a comment
There was a problem hiding this comment.
grammar suggestions - all set up inline to be easy to accept. I don't think I tweaked anything off what you're trying to say, but do double check please.
Signed-off-by: Adam Fowler <adamfower71@gmail.com> Co-authored-by: Joseph Heck <j_heck@apple.com> Signed-off-by: Adam Fowler <adamfowler71@gmail.com>
Signed-off-by: Adam Fowler <adamfowler71@gmail.com>
|
|
||
| Valkey-swift is a production-grade Swift client built with modern Swift features in mind. Using Valkey with Swift provides strongly typed APIs with clean semantics, memory-safety and data-race-safety guarantees, and a very light memory footprint. The API uses Swift's structured concurrency — a paradigm designed to bring clarity to concurrent programming by using the structure of your code to automatically define the lifetimes of tasks and associated resources. This allows you to write clean concurrent code without worrying about its side effects like race conditions and connection leaks. | ||
|
|
||
| ## Features |
There was a problem hiding this comment.
| ## Features | |
| ## Core Features |
|
|
||
| ## Features | ||
|
|
||
| Features included in our preview release of valkey-swift: |
There was a problem hiding this comment.
Would recommend this section be framed around core features vs features that were included in the preview release. I assume these are largely the same, but framing the content this way may be clarifying for the reader who is looking to understand what's included in the 1.0 release.
There was a problem hiding this comment.
| Features included in our preview release of valkey-swift: | |
| valkey-swift includes these core features: |
There was a problem hiding this comment.
The point of this section was to detail what was in the preview release and what has been done since
Co-authored-by: Dave Lester <18080+davelester@users.noreply.github.com> Signed-off-by: Adam Fowler <adamfowler71@gmail.com>
Co-authored-by: Dave Lester <18080+davelester@users.noreply.github.com> Signed-off-by: Adam Fowler <adamfowler71@gmail.com>
Description
Valkey-swift 1.0 announcement blog post
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.