CMake support #33
Open
CMake support #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairgott
requested changes
Feb 5, 2025
yairgott
requested changes
Feb 5, 2025
|
The changes look good to me! I noticed there are still two unresolved comments: porting the tests and build.sh. I’ll do a more thorough review once those are addressed. |
Signed-off-by: Eran Ifrah <[email protected]>
- Added LTO to the various targets - Match compile flags as defined in `.bazelrc` to CMake - Fixed typo - Suppressed warnings - Creaet symbolik link for compile_commands.json Signed-off-by: Eran Ifrah <[email protected]>
- Build tests - Added build script (run: build.sh --help) Signed-off-by: Eran Ifrah <[email protected]>
yairgott
requested changes
Feb 15, 2025
eifrah-aws
force-pushed
the
cmake
branch
3 times, most recently
from
fb309bc to
9a31afc
Compare
eifrah-aws
force-pushed
the
cmake
branch
2 times, most recently
from
88cfc96 to
3efea19
Compare
- Changed clone URL to https version - Updated BUILD_cmake.md - Fixed LTO build error for UT - build.sh script: added --run-test option - Added missing build flags: -DBAZEL_BUILD, -Wno-unknown-pragmas - Ensured that all UT are passing - Do not rebuild on consecutive calls for cmake when nothing was changed - Added missing tests: vmsdk/testing - Reduced CMake requirement to 3.16 - Fixed memory allocation test on GCC 13 - Added script timer - Support build on arm Signed-off-by: Eran Ifrah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR,
valkey-searchcan be built withCMake.Build instructions where added to the
BUILD_cmake.md.Point to take into consideration while reviewing this PR:
OpenSSL
OpenSSL used, is the system SSL (this is similar to how
valkeyworks)Submodules
Submodules are being pulled and built during the
cmakestage. The first time you runcmakeit might took a while (due togit clone + build), consecutive calls forcmakeare much faster.The rationale behind this, is that submodules are rarely changed so there is no need to rebuild them after each
makecall (even if CMake will just reportBuilt target)How to build & run
To build:
To run: