-
Notifications
You must be signed in to change notification settings - Fork 954
Send duplicate multi meet packet only for node which supports it #2840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
Send duplicate multi meet packet only for node which supports it #2840
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #2840 +/- ##
============================================
- Coverage 72.46% 72.41% -0.05%
============================================
Files 128 128
Lines 70364 70370 +6
============================================
- Hits 50986 50961 -25
- Misses 19378 19409 +31
🚀 New features to boost your workflow:
|
Signed-off-by: Harkrishn Patro <[email protected]>
e482520 to
abf06e7
Compare
|
Bump. This one is a blocker for us for upgrading to 8.1. During upgrade we have a mixed cluster with 8.0 and 8.1. |
zuiderkwast
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Why is this still a draft? Anything missing?
We should include this fix in the next patch release.
| /* Check if the node can handle multi meet packet. */ | ||
| if (flags & CLUSTER_NODE_MULTI_MEET_SUPPORTED) { | ||
| sender->flags |= CLUSTER_NODE_MULTI_MEET_SUPPORTED; | ||
| } else { | ||
| sender->flags &= ~CLUSTER_NODE_MULTI_MEET_SUPPORTED; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't really need this code, because CLUSTER_NODE_MULTI_MEET_SUPPORT == CLUSTER_NODE_LIGHT_HDR_MODULE_SUPPORTED and we already have the same code for CLUSTER_NODE_LIGHT_HDR_MODULE_SUPPORTED. We rely on them being equal for the compatibility logic (e.g. when running a mixed cluster with 8.1.0 and 8.1.5).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is dead code but added for folks not to get confused.
I think the code is good. However, couldn't create a test to reproduce the issue. |
OK, then I'd like to merge this as is. I trust it because it modifies only the |
Fixes: #2341
Would need to backport this to 9.0 and 8.1