Skip to content

Conversation

@martinrvisser
Copy link

Closes #2590 : adding more client flags for module usage:
VALKEYMODULE_CLIENTINFO_FLAG_PRIMARY (1 << 7)
VALKEYMODULE_CLIENTINFO_FLAG_REPLICA (1 << 8)
VALKEYMODULE_CLIENTINFO_FLAG_MONITOR (1 << 9)
VALKEYMODULE_CLIENTINFO_FLAG_MODULE (1 << 10)
VALKEYMODULE_CLIENTINFO_FLAG_AUTHENTICATED (1 << 11)
VALKEYMODULE_CLIENTINFO_FLAG_EVER_AUTHENTICATED (1 << 12)
VALKEYMODULE_CLIENTINFO_FLAG_FAKE (1 << 13)

@rjd15372
Copy link
Member

@martinrvisser you need to fix the commit message to include the signed-off line.

Can you also update the unit test test_clientifno in tests/modules/misc.c to include the new flags?

@martinrvisser
Copy link
Author

@rjd15372 updated the test and commit message

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.44%. Comparing base (8ea7f13) to head (481841c).
⚠️ Report is 15 commits behind head on unstable.

Files with missing lines Patch % Lines
src/module.c 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #2868      +/-   ##
============================================
- Coverage     72.44%   72.44%   -0.01%     
============================================
  Files           128      129       +1     
  Lines         70415    70499      +84     
============================================
+ Hits          51011    51070      +59     
- Misses        19404    19429      +25     
Files with missing lines Coverage Δ
src/module.c 9.76% <0.00%> (-0.02%) ⬇️

... and 19 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zuiderkwast
Copy link
Contributor

updated the test and commit message

You need it for all commits, including the old one, and the sign-off full name and email needs to match the author name and email. See the Details link next to the DCO job for how to fix it.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[NEW] extend VALKEYMODULE_CLIENTINFO_INITIALIZER_V1 with replica flags for ValkeyModule_GetClientInfoById

3 participants