-
Notifications
You must be signed in to change notification settings - Fork 957
support whole cluster info for INFO command in cluster section #2876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: zhaozhao.zz <[email protected]>
0ddb35a to
959c889
Compare
hpatro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this.
The only risk I would like to call out is we have been wary of increasing the info and info all command response size to avoid tail latency for other commands.
enjoy-binbin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok to me. Does anyone know the history? why we have this cluster section and have the CLUSTER INFO command.
ranshid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the same concern as @hpatro, since this would increase the latency when the cluster has a large number of nodes.
However, since info all command already performs horribly and the best practice is to explicitly define the sections of interest to avoid potential degradation I think this is fine
|
I have the same concern as @hpatro, since this would increase the latency when the cluster has a large number of nodes.
I can only imagine that it was meant to avoid bloating the already extensive info output. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #2876 +/- ##
============================================
+ Coverage 72.43% 72.45% +0.02%
============================================
Files 128 128
Lines 70439 70439
============================================
+ Hits 51022 51038 +16
+ Misses 19417 19401 -16
🚀 New features to boost your workflow:
|
Allow users to more easily get cluster information.