Allow parallelizeBuildables on iOS builds to improve build time#1724
Merged
mergify[bot] merged 93 commits intomainfrom Jan 17, 2022
Merged
Allow parallelizeBuildables on iOS builds to improve build time#1724mergify[bot] merged 93 commits intomainfrom
mergify[bot] merged 93 commits intomainfrom
Conversation
…ner which is now deprecated and causing tests to fail
…ApptestRelease error from gradle cache
… duplicate class build error
kathaypacific
commented
Jan 17, 2022
| await element(by.text('Connected Apps')).tap() | ||
| await element(by.text('Tap to Disconnect')).tap() | ||
| await element(by.text('Disconnect')).tap() | ||
| await element(by.id('BackChevron')).tap() |
Contributor
Author
There was a problem hiding this comment.
after apps are disconnected, the user is still on the Sessions screen but the next assertion for ConnectedApplications/value is on the Settings screen. because this assertion is in the afterAll hook, the tests failed without being captured by the test reports or test artifacts. i think for correctness the command to navigate back to the settings screen should exist...
(i also ran this test locally on the main branch, and it seems that the tests pass even though the app is still on the Sessions screen and the ConnectedApplications/value is not found :/ i'm not sure why it can pass, but the behaviour of disconnecting a connected app has not changed in this PR)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR is to enable us to use "dependency order" for the "build order". This is the default setting for xcode 13 and also since RN 0.62. The benefits include better build performance through more parallelisation and reduced dependency cycle errors.
To build in this way, dependencies need to require the
React-Corepod instead ofReact. For this reason, many dependencies needed to be updated. Where possible I have updated to the latest versions, some libs were deprecated so I have updated to the new recommended option.Of note:
New patches:
Other changes
Unlink react-native-geth and react-native-securerandom to resolve the below build warning. This was actually pretty straightforward, didn't cause any problems.
Tested
Manually
How others should test
A regression to see that app functionality hasn't been affected. e.g. QR scanning, app data persistence when force closing/opening the app.
Backwards compatibility
Yes