feat: add eventbus state check #578
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jyjiangkai <[email protected]>
hwjiangkai
changed the title
Signed-off-by: jyjiangkai <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #578 +/- ##
==========================================
- Coverage 57.07% 54.57% -2.50%
==========================================
Files 190 211 +21
Lines 15191 16977 +1786
==========================================
+ Hits 8670 9266 +596
- Misses 5884 7001 +1117
- Partials 637 710 +73
... and 56 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ifplusor
requested changes
Mar 27, 2023
| panic("invalid id") | ||
| } | ||
| bus := c.Eventbus(ctx, api.WithName("quick-start"), api.WithID(eventbusID.Uint64())) | ||
| bus, err := c.Eventbus(ctx, api.WithName("quick-start"), api.WithID(eventbusID.Uint64())) |
Collaborator
There was a problem hiding this comment.
Suggested change
| bus, err := c.Eventbus(ctx, api.WithName("quick-start"), api.WithID(eventbusID.Uint64())) | |
| bus, err := c.Eventbus(ctx, api.WithID(eventbusID.Uint64())) |
Signed-off-by: jyjiangkai <[email protected]>
Signed-off-by: jyjiangkai <[email protected]>
Signed-off-by: jyjiangkai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary
What is changed and how does it work?
Check List
Tests