Merged
Conversation
jelly
reviewed
Feb 17, 2025
Collaborator
jelly
left a comment
jelly
left a comment
There was a problem hiding this comment.
Additionally I would drop future as dependency in requirements.txt and test-requirements.txt.
Clean up the supported versions in setup.cfg so classifiers and python_requires.
And there is even more to clean up 🤯 in the setuptools requirements in setup.py and pyproject.toml everything with python_version < "3" can go away.
Additionally as a follow up I would like to move the setuptools_scm dependency to >= 7.0.0 so we can drop the obsolete and unmaintained setuptools_scm_git_archive dependency. I already did this in my Arch Linux PKGBUILD. (its out for 2 years now so should be good for distros)
behrmann
force-pushed
the
droppy2
branch
2 times, most recently
from
4b0d041 to
8fbabcc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.