varlink_generator: Fix generating code which compiles with Rust 2024#122
Merged
zeenix merged 2 commits intovarlink:masterfrom Mar 26, 2025
cryptomilk:asn-generator
Merged
varlink_generator: Fix generating code which compiles with Rust 2024#122zeenix merged 2 commits intovarlink:masterfrom cryptomilk:asn-generator
zeenix merged 2 commits intovarlink:masterfrom
cryptomilk:asn-generator
Conversation
Contributor
Author
|
Fixed. |
Contributor
Author
|
Ah, there is a second one. Fixed. |
Pull Request Test Coverage Report for Build 14084890847Details
💛 - Coveralls |
Contributor
Author
|
The linting reports are unrelated to this PR. |
Contributor
Yeah but CI needs to pass to merge. Could you please also fix the lints as well (in a separate commit (not PR) please)? Otherwise, I'll do it at some point and then rebase/merge this. |
Contributor
Author
|
Ok, I will look into it. |
Contributor
Author
|
Done. |
--> varlink/src/lib.rs:1056:53
|
1056 | ... .map_err(map_context!())
| _______________________________________________^
1057 | | ... .map_err(Error::from)?,
| |___________________________________________^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
This generates code which also compiles with Rust 2024. See https://doc.rust-lang.org/nightly/edition-guide/rust-2024/match-ergonomics.html Fixes #121
auto-merge was automatically disabled
March 26, 2025 13:46
Head branch was pushed to by a user without write access
Contributor
Author
|
I didn't run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This generates code which also compiles with Rust 2024.
See https://doc.rust-lang.org/nightly/edition-guide/rust-2024/match-ergonomics.html
Fixes #121