Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c3c69b5eb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| const normalizedCommand: FlowCommand = parsed.command === 'report' ? 'status' : parsed.command; | ||
| const state = buildFlowState({ useRemoteRefs: parsed.refreshRefs }); |
There was a problem hiding this comment.
Use local refs when
--refresh-refs cannot fetch
After refreshRefs() returns a warning (for example, no origin remote or a fetch failure), the code still forces buildFlowState to read origin/main and origin/dev. In that failure path, local main/dev data is ignored and the report/check degrades to false branch-missing/version-unknown errors even though local refs may be valid. This makes --refresh-refs brittle in offline or non-remote clones; useRemoteRefs should only be enabled when refresh actually succeeds.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
Promotes the OMA 2.1.3 dev lane to main by aligning repository metadata (repo slug rename), release tooling, packaging descriptors, and documentation for the vaur94/oma repository.
Changes:
- Bump root version to
2.1.3and update repo URLs/slugs across CLI upgrade, installer, packaging, security/docs, and changelog links. - Add a local release operator script (
release:flow) to report/check main/dev/tag/version readiness. - Add/adjust tests to cover the new release flow helpers and root package version parsing.
Reviewed changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| test/release-versioning.test.ts | Adds coverage for parsing stable-only root package versions. |
| test/release-flow.test.ts | New tests for release flow classification and readiness evaluation. |
| test/cli/upgrade-command.test.ts | Updates alpha tag fixtures to ensure --check path exercises “update available” output. |
| scripts/release/lib.ts | Refactors root version reading into a reusable parseRootPackageVersion. |
| scripts/release/flow.ts | Adds release:flow operator for status/check reporting of lanes and tags. |
| scripts/release/audit.ts | Updates audit regex to reflect new package/repo naming. |
| packaging/rpm/oma.spec | Updates summary and GitHub URL/source asset links to vaur94/oma. |
| packaging/nfpm.yaml | Updates description/homepage/bugs URLs to vaur94/oma. |
| packaging/deb/DEBIAN/control | Updates description/homepage/bugs URLs to vaur94/oma. |
| packages/cli/src/commands/upgrade.ts | Points upgrade checks to vaur94/oma releases endpoints. |
| package.json | Bumps version to 2.1.3, updates repository URL, adds release:flow script. |
| install.sh | Updates default repo + usage example URL to vaur94/oma. |
| docs/getting-started.md | Updates install/release links and documents release:flow usage. |
| bun.lock | Updates workspace name metadata to oma. |
| SECURITY.md | Updates advisory URL to the renamed repository. |
| RELEASE.md | Documents the new local release:flow operator. |
| README.tr.md | Updates install/release links and documents release:flow checks. |
| README.md | Updates install/release links and documents release:flow checks. |
| CHANGELOG.md | Rewrites GitHub compare/commit/issue links to point at vaur94/oma. |
| .gitleaks.toml | Updates config title to match renamed repository. |
| .github/ISSUE_TEMPLATE/config.yml | Updates security advisory contact link to the renamed repository. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ```bash | ||
| curl -fsSL https://raw.githubusercontent.com/vaur94/open-multi-agent/main/install.sh | sh -s -- --channel alpha --version v2.1.2-alpha.3 | ||
| curl -fsSL https://raw.githubusercontent.com/vaur94/oma/main/install.sh | sh -s -- --channel alpha --version v2.1.2-alpha.3 |
There was a problem hiding this comment.
The alpha pin example still uses v2.1.2-alpha.3. If 2.1.3 is now the promoted release, consider updating this to a current tag (or vX.Y.Z-alpha.N) so the README examples don't age immediately.
| curl -fsSL https://raw.githubusercontent.com/vaur94/oma/main/install.sh | sh -s -- --channel alpha --version v2.1.2-alpha.3 | |
| curl -fsSL https://raw.githubusercontent.com/vaur94/oma/main/install.sh | sh -s -- --channel alpha --version vX.Y.Z-alpha.N |
|
|
||
| ```bash | ||
| curl -fsSL https://raw.githubusercontent.com/vaur94/open-multi-agent/main/install.sh | sh -s -- --channel alpha --version v2.1.2-alpha.3 | ||
| curl -fsSL https://raw.githubusercontent.com/vaur94/oma/main/install.sh | sh -s -- --channel alpha --version v2.1.2-alpha.3 |
There was a problem hiding this comment.
The alpha pin example still uses v2.1.2-alpha.3. If 2.1.3 is now the promoted release, consider updating this to a current tag (or vX.Y.Z-alpha.N) so the examples stay current.
| curl -fsSL https://raw.githubusercontent.com/vaur94/oma/main/install.sh | sh -s -- --channel alpha --version v2.1.2-alpha.3 | |
| curl -fsSL https://raw.githubusercontent.com/vaur94/oma/main/install.sh | sh -s -- --channel alpha --version vX.Y.Z-alpha.N |
| } | ||
|
|
||
| export function readRootVersion(rootPackagePath: string): string { | ||
| return parseRootPackageVersion(readFileSync(rootPackagePath, 'utf8')); |
There was a problem hiding this comment.
The thrown error from readRootVersion() will now lose the rootPackagePath context because parseRootPackageVersion() returns a generic message. Consider keeping parseRootPackageVersion() generic, but wrapping errors in readRootVersion() (or including the path in the message) so callers can identify which file was invalid.
| return parseRootPackageVersion(readFileSync(rootPackagePath, 'utf8')); | |
| try { | |
| return parseRootPackageVersion(readFileSync(rootPackagePath, 'utf8')); | |
| } catch (error) { | |
| const originalMessage: string = | |
| error instanceof Error ? error.message : String(error); | |
| throw new Error( | |
| `Failed to read root version from ${rootPackagePath}: ${originalMessage}` | |
| ); | |
| } |
| { | ||
| label: 'bun global install package docs', | ||
| pattern: /bun\s+install\s+-g\s+@vaur94\/open-multi-agent/i, | ||
| pattern: /bun\s+install\s+-g\s+(@vaur94\/oma|oma)\b/i, |
There was a problem hiding this comment.
This regex will also match packages like oma-cli or oma-tools because \b treats - as a word boundary. If the intent is to forbid only bun install -g oma (or @vaur94/oma), anchor the package token to whitespace/end-of-line (e.g., (?:\s|$)) to avoid false positives in the audit.
| pattern: /bun\s+install\s+-g\s+(@vaur94\/oma|oma)\b/i, | |
| pattern: /bun\s+install\s+-g\s+(@vaur94\/oma|oma)(?:\s|$)/i, |
|
|
||
| ```bash | ||
| curl -fsSL https://raw.githubusercontent.com/vaur94/open-multi-agent/main/install.sh | sh -s -- --version v2.1.2 | ||
| curl -fsSL https://raw.githubusercontent.com/vaur94/oma/main/install.sh | sh -s -- --version v2.1.2 |
There was a problem hiding this comment.
The pinned stable install example still references v2.1.2, but this PR bumps the root version to 2.1.3. Update the example to v2.1.3 (or use a placeholder like vX.Y.Z) to avoid immediately-stale docs.
| curl -fsSL https://raw.githubusercontent.com/vaur94/oma/main/install.sh | sh -s -- --version v2.1.2 | |
| curl -fsSL https://raw.githubusercontent.com/vaur94/oma/main/install.sh | sh -s -- --version vX.Y.Z |
| For a reproducible install, pin an explicit release: | ||
|
|
||
| ```bash | ||
| curl -fsSL https://raw.githubusercontent.com/vaur94/open-multi-agent/main/install.sh | sh -s -- --version v2.1.2 | ||
| curl -fsSL https://raw.githubusercontent.com/vaur94/oma/main/install.sh | sh -s -- --version v2.1.2 | ||
| ``` |
There was a problem hiding this comment.
The pinned stable install example still references v2.1.2, but this PR promotes 2.1.3 and bumps the root package.json version. Update the example to v2.1.3 (or a placeholder) so the README doesn't point to an old tag.
| Tekrarlanabilir kurulum için belirli bir sürümü sabitleyin: | ||
|
|
||
| ```bash | ||
| curl -fsSL https://raw.githubusercontent.com/vaur94/open-multi-agent/main/install.sh | sh -s -- --version v2.1.2 | ||
| curl -fsSL https://raw.githubusercontent.com/vaur94/oma/main/install.sh | sh -s -- --version v2.1.2 | ||
| ``` |
There was a problem hiding this comment.
The pinned stable install example still references v2.1.2, but this PR promotes 2.1.3 and bumps the root package.json version. Update the example to v2.1.3 (or a placeholder) so this localized README stays consistent with the current release.
|
|
||
| ```bash | ||
| curl -fsSL https://raw.githubusercontent.com/vaur94/open-multi-agent/main/install.sh | sh -s -- --channel alpha --version v2.1.2-alpha.3 | ||
| curl -fsSL https://raw.githubusercontent.com/vaur94/oma/main/install.sh | sh -s -- --channel alpha --version v2.1.2-alpha.3 |
There was a problem hiding this comment.
The alpha pin example still uses v2.1.2-alpha.3. Since this PR is promoting 2.1.3 and updating repo metadata, consider updating this example to a current tag (or a placeholder like vX.Y.Z-alpha.N) to avoid suggesting an outdated prerelease.
| curl -fsSL https://raw.githubusercontent.com/vaur94/oma/main/install.sh | sh -s -- --channel alpha --version v2.1.2-alpha.3 | |
| curl -fsSL https://raw.githubusercontent.com/vaur94/oma/main/install.sh | sh -s -- --channel alpha --version vX.Y.Z-alpha.N |
Summary
release:flowoperator script and repo slug cleanup tovaur94/omaValidation