Skip to content

fix issues identified by rtsan and update juce #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vberthiaume merged 50 commits into from
Dec 22, 2025
Merged

fix issues identified by rtsan and update juce #66

vberthiaume merged 50 commits into from
Dec 22, 2025

Conversation

@vberthiaume
Copy link
Owner

@vberthiaume vberthiaume commented Dec 22, 2025

closes #58

@vberthiaume
remove locks in juce::Syntesiser
e7bd8df
@vberthiaume
add comment on osc.initialize. Some faffing in the .vscode config fil…
3f10c69 
…es that will need to be undone/fixed for mac
@vberthiaume
remove osc init from audio thread
7a88a1f
@vberthiaume
faff
56fe364
@vberthiaume
farbot
dfff46b
@vberthiaume
attempt
fd8d186
@vberthiaume
building
48ab8fb
@vberthiaume
make curSelection atomic
d513263
@vberthiaume
json
6e49826
@vberthiaume
wip -- attempt to use CRTP for the Selection class [skip ci]
8af75c8
@vberthiaume
cleanup json [skip ci]
b3c7a0c
@vberthiaume
remove CRTP stuff
bb74891
@vberthiaume
start the array of lfos [skip ci]
b054c36
@vberthiaume
wip
37b9e1f
@vberthiaume
more wip -- not sure about this at all lol
21e4758
@vberthiaume
bring the useful bits from the locksNeedsRebase branch
1cb0b07
@vberthiaume
building
af314e8
@vberthiaume
fixing build and some warnings
2e08358
@vberthiaume
cleanup, only missing random lfo init
efe6ceb
@vberthiaume
comment
869a152
@vberthiaume
cleanup. builds but asserts at runtime -- actually need to swap them …
f64461d 
…lfos bro
@vberthiaume
put logic in to change the lfo shape, but somehow we always get shape…
3854691 
… == 0
@vberthiaume
cleanup and don't make the lfo random a table, just call the lambda. …
a566999 
…Which may instroduce system calls to random and break rtsan
@vberthiaume
comment
cb21d93
@vberthiaume
wip - building not running [skip ci]
c9af456
@vberthiaume
cleanup
a21f156
@vberthiaume
remove processor chain
1fc19db
@vberthiaume
remove updateOscillators. We can run but get an assert when changing …
63210b6 
…oscillators. Logic for noise osc needs to be analyzed
@vberthiaume
fix assert
f0a9c62
@vberthiaume
cleanup and made sure the noise osc logic was sound 🚀
95f7438
@vberthiaume vberthiaume merged commit 56d3077 into main Dec 22, 2025
10 checks passed
@vberthiaume vberthiaume deleted the locks branch December 22, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix RTSan issues

2 participants

@vberthiaume