Skip to content

Fix heap-buffer-overflow in legacy maps section parsing #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elazarg merged 1 commit into from
Mar 11, 2026
+9 −1
Merged

Fix heap-buffer-overflow in legacy maps section parsing #1052

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/io/elf_map_parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,12 +215,20 @@ ElfGlobalData parse_map_sections(const parse_params_t& parse_params, const ELFIO
if (max_record_end > s->get_size()) {
throw UnmarshalError("Malformed legacy maps section: " + s->get_name());
}
map_count = (max_record_end + map_record_size - 1) / map_record_size;
// Use floor division to ensure map_count * map_record_size <= section size.
// Ceiling division can produce a count whose last record extends past the buffer,
// causing a heap-buffer-overflow in the platform's parse_maps_section callback.
map_count = max_record_end / map_record_size;
}

section_record_sizes[i] = map_record_size;
section_base_index[i] = base_index;

// Safety invariant: all records must fit within the section data.
if (map_count * map_record_size > s->get_size()) {
throw UnmarshalError("Malformed legacy maps section: " + s->get_name());
}

parse_params.platform->parse_maps_section(global.map_descriptors, s->get_data(), map_record_size,
gsl::narrow<int>(map_count), parse_params.platform,
parse_params.options);
Expand Down
Loading