Skip to content

Fix a lot of stuff#17

Merged
misiokles merged 5 commits intovcmi-mods:vcmi-1.7from
Karyoplasma:typo
Mar 22, 2026
Merged

Fix a lot of stuff#17
misiokles merged 5 commits intovcmi-mods:vcmi-1.7from
Karyoplasma:typo

Conversation

@Karyoplasma
Copy link
Contributor

@Karyoplasma Karyoplasma commented Mar 19, 2026

PR fixes:

  • case typos and superfluous spaces after { or before }.
    • also added a missing letter to the combat options: artillery help text.
  • Titan Bolt having the incorrect name and description (used the one from Fear Spell which doesn't exist in VCMI)
  • several artifacts with badly translated descriptions
    • one with a wrong name: Vial of Dragon's Blood is called "Blut des Drachen" in German, compare to bio of Mutare Drake
  • descriptions of the elemental summon spells (tested, length is fine)
  • Miner's Guild saying it increases production per DAY (this was a bug in the original localization)
  • line breaks causing issues in arraytxt (I replaced all \r\n with \n across the entire file, doesn't cause issues in descriptions but is easier to read - the engine expects \n instead of \r\n because that's how the original game files are structured: \r\n denotes a new entry, while \n denotes a line break within a string. Fixes Spacing in Morale/Luck Modifiers is off #19
  • names of creature banks
  • inconsistency in Cloak of the Undead King: all creatures were called their unupgraded names except zombies (bug in original localization)
  • advevent.txt for shines (required to start with a space because of how they are concatenated)

@Laserlicht @misiokles

@Karyoplasma Karyoplasma changed the title Fix a typo Fix some typos and superfluous spaces Mar 19, 2026
@Karyoplasma Karyoplasma changed the title Fix some typos and superfluous spaces Fix a lot of stuff Mar 21, 2026
@misiokles misiokles merged commit ac17367 into vcmi-mods:vcmi-1.7 Mar 22, 2026
@Karyoplasma Karyoplasma deleted the typo branch March 22, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spacing in Morale/Luck Modifiers is off

3 participants