enhancement(vector): Add namespace to manifests

[mustdiechik]

fix
#394

[pront]

Hi @mustdiechik and thank you for this PR.

Was this #394 (comment) fixed?

[pront]

Hmm, this PR seems identical to #394 but the lint check passes for me locally:

❯ helm lint charts/vector --values /Users/pavlos.rontidis/CLionProjects/helm-charts/charts/vector/examples/datadog-values.yaml
==> Linting charts/vector

1 chart(s) linted, 0 chart(s) failed

[jszwedko]

Hmm, this PR seems identical to #394 but the lint check passes for me locally:

❯ helm lint charts/vector --values /Users/pavlos.rontidis/CLionProjects/helm-charts/charts/vector/examples/datadog-values.yaml
==> Linting charts/vector

1 chart(s) linted, 0 chart(s) failed

It's very subtle, but, at least one difference is, that the old PR used .Release.Namespace in secret.yaml where this PR uses $.Release.Namespace (note the leading $).

[pront]

Hmm, this PR seems identical to #394 but the lint check passes for me locally:

❯ helm lint charts/vector --values /Users/pavlos.rontidis/CLionProjects/helm-charts/charts/vector/examples/datadog-values.yaml
==> Linting charts/vector

1 chart(s) linted, 0 chart(s) failed

It's very subtle, but, at least one difference is, that the old PR used .Release.Namespace in secret.yaml where this PR uses $.Release.Namespace (note the leading $).

Gotcha, will this PR to you if you don't mind.

I also noticed a failing CI check: https://github.com/vectordotdev/helm-charts/actions/runs/12684331521/job/35380313928?pr=441

[jszwedko]

Hmm, this PR seems identical to #394 but the lint check passes for me locally:

❯ helm lint charts/vector --values /Users/pavlos.rontidis/CLionProjects/helm-charts/charts/vector/examples/datadog-values.yaml
==> Linting charts/vector

1 chart(s) linted, 0 chart(s) failed

It's very subtle, but, at least one difference is, that the old PR used .Release.Namespace in secret.yaml where this PR uses $.Release.Namespace (note the leading $).

Gotcha, will this PR to you if you don't mind.

I also noticed a failing CI check: https://github.com/vectordotdev/helm-charts/actions/runs/12684331521/job/35380313928?pr=441

Oof, those checks were actually failing on #439 when it merged. Let me double check the branch protection settings.

[jszwedko]

Thanks @mustdiechik !