feat(lz4 encoder/decoder): add support for Lz4 encode and decode #1339
+233
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jimmystewpot, 1337 indeed. There are a few failing checks and we will also need a sibling PR in Vector to document this function. Otherwise, LGTM! |
10 tasks
|
The vector PR for documentation updates should be now available here vectordotdev/vector#22702 |
pront
reviewed
Mar 21, 2025
pront
approved these changes
Mar 24, 2025
There was a problem hiding this comment.
One small failure to address: https://github.com/vectordotdev/vrl/actions/runs/13983003461/job/39321067362?pr=1339
auto-merge was automatically disabled
March 24, 2025 21:03
Head branch was pushed to by a user without write access
Thanks, I've updated the filename. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change aims to introduce support for LZ4 encoding and decoding. We currently use lz4 compression on (some of) our observability pipelines to help with costs and bandwidth utilisation. We reached out to see if this was something that we could contribute to the community in issue #1337 (it is only now that I realise how l33t that issue ID is.. lol)
Change Type
Is this a breaking change?
How did you test this PR?
To minimise the review effort, I have mirrored the test styles and layout from other encoders and decoders. Specifically, I modelled it after the snappy one.
Does this PR include user-facing changes?
our guidelines.
Checklist
run
dd-rust-license-tool writeand commit the changes. More details here.References