Skip to content

fix: Ungroup pathmarks in offset channels also for aggregated fields#9821

Open
joelostblom wants to merge 1 commit into
mainfrom
fix/ungroup-agg-marks-across-offsets
Open

fix: Ungroup pathmarks in offset channels also for aggregated fields#9821
joelostblom wants to merge 1 commit into
mainfrom
fix/ungroup-agg-marks-across-offsets

Conversation

@joelostblom
Copy link
Copy Markdown
Contributor

PR Description

I missed testing with aggregated field properly in #9819, so an aggregation in the offset channel currently connects pathmarks incorrectly:
image

After this PR, pathmarks are correctly ungrouped also for aggregated fields:
image

Spec for testing:

{
  "data": {
    "values": [
      {"a": "A", "b": 28, "c": "x", "d": "m"},
      {"a": "B", "b": 55, "c": "x", "d": "m"},
      {"a": "C", "b": 43, "c": "x", "d": "n"},
      {"a": "D", "b": 91, "c": "x", "d": "n"},
      {"a": "A", "b": 88, "c": "y", "d": "m"},
      {"a": "B", "b": 55, "c": "y", "d": "m"},
      {"a": "C", "b": 43, "c": "y", "d": "n"},
      {"a": "D", "b": 55, "c": "y", "d": "n"},

    ]
  },
  "mark": {"type": "line"},
  "encoding": {
    "x": {"field": "a"},
    "yOffset": {"field": "b", "aggregate": "sum", "type": "quantitative"},
    "y": {"field": "c"}
  }
}

Checklist

  • This PR is atomic (i.e., it fixes one issue at a time).
  • The title is a concise semantic commit message (e.g. "fix: correctly handle undefined properties").
  • npm test runs successfully
  • For new features:
    • Has unit tests.
    • Has documentation under site/docs/ + examples.

Tips:

@joelostblom joelostblom requested a review from a team as a code owner April 10, 2026 08:45
@domoritz
Copy link
Copy Markdown
Member

See #9819 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants