fix: recalculate labelAlign and labelBaseline after repositioning dual axes#9825
Open
datananda wants to merge 1 commit into
Open
Conversation
…al-axis layers (vega#3773) When parseLayerAxes() repositions a second axis to the opposite orient, labelAlign and labelBaseline (already computed for the original orient) were stale. Resolve labelAngle from all sources using getLabelAngle (matching parseAxis), then recompute both properties for the new orient. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3773
When parseLayerAxes() repositions a second axis to the opposite orient, labelAlign and labelBaseline (already computed for the original orient) were stale. Resolve labelAngle from all sources (axis or config) using getLabelAngle (matching parseAxis), then recompute both properties for the new orient.
Using the example from the reported issue:
before (config labelAngle 0)

after


PR Description
Checklist
npm testruns successfullysite/docs/+ examples.Tips: