fix(tick): respect bandSize in tick sizing#9827
Conversation
|
Thanks for taking a look. I’ve implemented the |
|
Thanks for making the PR! I think this could make sense technically to restore the effect of Let's wait to hear if someone else on the team with more historical context around why |
|
Thanks for the thoughtful feedback; that makes sense. My initial assumption was that since If the intent is for Happy to adjust the PR in either direction depending on what’s preferred, whether that’s keeping the current fix or aligning with a documentation/cleanup change. |
|
Thanks @Adeyinka1 for suggesting the fix! (thanks for pinging me @joelostblom ) I prefer changing the documentation (remove |
|
Thanks @yhoonkim for the clarification; that direction sounds good to me. I will update the PR to align with using |
|
I have updated the PR to follow the documentation/config cleanup direction:
I also reran the targeted tick tests locally after the change. |
Summary
This PR fixes an issue where
bandSizeis defined inTickConfigbut has no effect on tick marks. close #9767Problem
Currently:
sizecontrols tick thickness correctlybandSizeis ignored for tick marksThis creates inconsistency between configuration and rendering behavior.
Solution
getBandSize()for tick marksbandSizeis used whensizeis not explicitly providedsizecontinues to take precedenceChanges
src/channeldef.tsto includebandSizefallback for tick marksbandSizeis respected whensizeis absentsizeoverridesbandSizewhen both are definedTesting