Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify parseConfigTemplates implementation #833

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Simplify parseConfigTemplates implementation #833

merged 1 commit into from
Oct 23, 2024

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Oct 22, 2024 •
edited
Loading

Description

The PR refactors unexported function parseConfigTemplates.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor

Version of Go used when building/testing:

  • 1.22
  • 1.23

How Has This Been Tested?

Check unit tests.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@LandonTClipp LandonTClipp merged commit f1e8da9 into vektra:master Oct 23, 2024
4 checks passed
@LandonTClipp
Copy link
Collaborator

LandonTClipp commented Oct 23, 2024 •
edited
Loading

Thanks! You are on a refactoring/cleanup rampage :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @LandonTClipp