pyth lazer cranker

[moosecat2]

No description provided.

[Copilot]

Pull Request Overview

This PR enhances the Pyth Lazer cranker by making the subscription channel configurable, adding control over simulation behavior, and refining interval and compute unit logic.

• Introduces subscribeChannel parameter to PythLazerSubscriber and exposes it via config
• Adds skipSimulation and pythLazerIds to bot config and implements branching for simulation vs. direct send
• Refactors default interval handling and adjusts compute unit limits

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/pythLazerSubscriber.ts	Added Channel import, subscribeChannel parameter, updated constructor usage
src/config.ts	Added new optional config fields: skipSimulation, pythLazerChannel, pythLazerIds
src/bots/pythLazerCranker.ts	Updated imports, default interval logic, skipSimulation branch, compute unit limits, and debug logs

Comments suppressed due to low confidence (6)

src/bots/pythLazerCranker.ts:37

• Typo in constant name: DEFAULT_INTEVAL_MS should be DEFAULT_INTERVAL_MS for consistency and clarity.

const DEFAULT_INTEVAL_MS = 30000;

src/bots/pythLazerCranker.ts:91

• [nitpick] Consider replacing console.log calls with a structured logger (e.g., logger.debug) to maintain consistency with other log statements.

console.log(feedIdChunks);

src/config.ts:123

• [nitpick] Add JSDoc or inline comments explaining the purpose and effect of skipSimulation to improve configuration clarity.

skipSimulation?: boolean;

src/pythLazerSubscriber.ts:30

• [nitpick] Consider documenting the new subscribeChannel parameter in the constructor (e.g., via JSDoc) to clarify its expected values.

private subscribeChannel = 'fixed_rate@200ms'

src/bots/pythLazerCranker.ts:199

• Introduce unit or integration tests covering both branches of skipSimulation to ensure reliability across simulation and direct send modes.

if (!this.crankConfigs.skipSimulation) {

src/bots/pythLazerCranker.ts:176

• Reducing the compute unit limit from 1_400_000 to 30_000 may cause transactions to exceed the allowed compute units and fail. Verify this change aligns with expected on-chain requirements.

units: 30_000,

[Copilot]

[nitpick] This debug log may not be needed in production; consider removing it or using an appropriate logging level.

Suggested change

	console.log(this.crankConfigs.pythLazerChannel);
	logger.debug(`PythLazerChannel: ${this.crankConfigs.pythLazerChannel}`);