-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/http and log #64
Fix/http and log #64
Conversation
@aabril Thanks for creating the PR! I'll do a code review and my local validation later, but could you please fix the CI error first? It seems to be a format error, so I think it can be fixed by running the following command and committing it. v fmt -w . |
formatting fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aabril LGTM ! Thank you !
@@ -118,7 +118,7 @@ pub fn (mut s ServeCommand) run() ! { | |||
} | |||
mut server := &http.Server{ | |||
handler: handler | |||
port: commands.cport | |||
addr: ':${commands.cport}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fn init_logger() &log.Log { | ||
mut l := log.Log{} | ||
l.set_level(.info) | ||
return &l |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was having this couple of errors:
Running in macos / macbook air m3
and v version:
V 0.4.7 7baff15
.Here are the fixes I did to make it work in my local.