Fix display width and height of canvas for non-responsive charts#5
Open
mharmer wants to merge 1 commit intovendrinc:masterfrom
Open
Fix display width and height of canvas for non-responsive charts#5mharmer wants to merge 1 commit intovendrinc:masterfrom
mharmer wants to merge 1 commit intovendrinc:masterfrom
Conversation
This is the final fix for vendrinc#3 to properly set the canvas size when using a non-responsive chart. If responsive is used, this width and height seem to be ignored and the chart should properly size to the window dimensions.
Contributor
Author
|
@aaronwhite: Soft ping on this. Also, if this goes in is it possible to get a new package release with the fixes? I would like to apply it to my project if possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the final fix for #3 to properly set the canvas size when using a non-responsive chart. If responsive is used, this width and height seem to be ignored and the chart should properly size to the window dimensions.
Per this SO answer using the JS approach should properly change the display size of the canvas. This is used rather than the chart attribute approach since it would technically affect the drawing buffer. Although visually these looked the same, it seems the former approach is probably the better approach.
This change is needed, as it seems the default width/height of the canvas is 300x150.