WIP: Retry-on-failure using requests' session adapter #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from the original Repo
krakenex pull request #2
krakenex pull request #3
Update master from base repo
Merge current master into ENH_requests-retry-2 branch
Also, now is more stricter on "bad configs": previously, it would do nothing; now, it raises exceptions.
No need to reference https://www.peterbe.com/plog/best-practice-with-retries-with-requests as documentation. It's not, strictly speaking, "documentation". ;) This is: https://urllib3.readthedocs.io/en/latest/reference/urllib3.util.html#module-urllib3.util.retry Squashed-in: api: increase default backoff factor + reorder args back.
This was referenced Sep 12, 2018
veox
changed the title
This was referenced Feb 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates PR #78. After that:
retry_config:forcelist->codesretries->countbackoff->backoff(no change)This PR:
I think there might be issues with this approach, though:
query, theadaptergets re-created - this is rather ungraceful;adapterstays with thesessionand is used even ifretry=Falseis specified in a follow-upquery.