Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pdf version #18

Open
wants to merge 171 commits into
base: customizations-for-tagged-pdf
Choose a base branch
from

Conversation

A1Kiselev
Copy link

No description provided.

Snuffleupagus and others added 30 commits June 30, 2024 15:16
Bump the stable version in `pdfjs.config`
[Editor] Take into account the page translation when computing the quadpoints when saving an highlight
…aining editable annotations

Right now, editable annotations are using their own canvas when they're drawn, but
it induces several issues:
 - if the annotation has to be composed with the page then the canvas must be correctly
   composed with its parent. That means we should move the canvas under canvasWrapper
   and we should extract composing info from the drawing instructions...
   Currently it's the case with highlight annotations.
 - we use some extra memory for those canvas even if the user will never edit them, which
   the case for example when opening a pdf in Fenix.

So with this patch, all the editable annotations are drawn on the canvas. When the
user switches to editing mode, then the pages with some editable annotations are redrawn but
without them: they'll be replaced by their counterpart in the annotation editor layer.
[api-minor][Editor] When switching to editing mode, redraw pages containing editable annotations (bug 1883884)
Co-authored-by: Jonas Jenwald <[email protected]>
[Editor] Make sure everything is cleaned up when we switch to annotation editor mode
[api-minor] Remove the deprecated `renderTextLayer` and `updateTextLayer` functions (PR 18104 follow-up)
Use vertical variant of a char when it's in a missing vertical font (bug 1905623)
…sFile

[Firefox] Generate a PDF.js default-prefs file that can be used directly in mozilla-central (bug 1905864)
Update dependencies and translations to the most recent versions
Make sure the editor is visible before getting its rect
Fix the integration tests related to printing
…lag`

In *hindsight* this seems like a better idea, since it avoids the need to manually pass `isEditing` around as a boolean value.
Note that `RenderingIntentFlag` is *internal* functionality, not exposed in the official API, which means that it can be extended and modified as necessary.
…ag-IS_EDITING

Move the internal API/Worker `isEditing`-state into `RenderingIntentFlag`
… method

Similar to the `mustBeViewed` method, we can check the relevant parameters within the `mustBeViewedWhenEditing` method itself since that (in my opinion) slightly helps readability of the code in the `src/core/document.js` file.
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants