forked from mozilla/pdf.js
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pdf version #18
Open
A1Kiselev
wants to merge
171
commits into
customizations-for-tagged-pdf
Choose a base branch
from
update-pdf-version
base: customizations-for-tagged-pdf
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yer` functions (PR 18104 follow-up)
Bump the stable version in `pdfjs.config`
…adpoints when saving an highlight It fixes mozilla#18360.
[Editor] Take into account the page translation when computing the quadpoints when saving an highlight
…aining editable annotations Right now, editable annotations are using their own canvas when they're drawn, but it induces several issues: - if the annotation has to be composed with the page then the canvas must be correctly composed with its parent. That means we should move the canvas under canvasWrapper and we should extract composing info from the drawing instructions... Currently it's the case with highlight annotations. - we use some extra memory for those canvas even if the user will never edit them, which the case for example when opening a pdf in Fenix. So with this patch, all the editable annotations are drawn on the canvas. When the user switches to editing mode, then the pages with some editable annotations are redrawn but without them: they'll be replaced by their counterpart in the annotation editor layer.
…tly in mozilla-central (bug 1905864)
[api-minor][Editor] When switching to editing mode, redraw pages containing editable annotations (bug 1883884)
Co-authored-by: Jonas Jenwald <[email protected]>
Bump library version to 4.5
[Editor] Make sure everything is cleaned up when we switch to annotation editor mode
[api-minor] Remove the deprecated `renderTextLayer` and `updateTextLayer` functions (PR 18104 follow-up)
Use vertical variant of a char when it's in a missing vertical font (bug 1905623)
…sFile [Firefox] Generate a PDF.js default-prefs file that can be used directly in mozilla-central (bug 1905864)
Update dependencies and translations to the most recent versions
Make sure the editor is visible before getting its rect
Fix the integration tests related to printing
[Editor] Remove the option enableStamp
…lag` In *hindsight* this seems like a better idea, since it avoids the need to manually pass `isEditing` around as a boolean value. Note that `RenderingIntentFlag` is *internal* functionality, not exposed in the official API, which means that it can be extended and modified as necessary.
…ag-IS_EDITING Move the internal API/Worker `isEditing`-state into `RenderingIntentFlag`
… method Similar to the `mustBeViewed` method, we can check the relevant parameters within the `mustBeViewedWhenEditing` method itself since that (in my opinion) slightly helps readability of the code in the `src/core/document.js` file.
Co-authored-by: Vladimir <[email protected]>
…x) (#6) Co-authored-by: Vladimir <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
KateOrient
force-pushed
the
customizations-for-tagged-pdf
branch
from
November 12, 2024 07:37
5ccd3c5
to
d46d472
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.