Next.js新分支 #86174
Next.js新分支 #86174
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a GitHub Actions workflow for building the Next.js project using Webpack. The workflow is configured to run on pushes and pull requests to the canary branch, testing against multiple Node.js versions.
Key Changes:
- Adds automated CI/CD workflow for Webpack builds
- Configures matrix testing across Node.js versions 18.x, 20.x, and 22.x
- Implements basic build steps using npm and webpack
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Build | ||
| run: | | ||
| npm install | ||
| npx webpack |
There was a problem hiding this comment.
The new workflow runs npm install followed by npx webpack, but this repository is configured for pnpm workspaces and does not include a root-level webpack entry/config. As written the job will consistently fail on every push/PR to canary because webpack cannot find a project to build (and npm will also ignore the existing pnpm lockfile), so the workflow never succeeds.
Useful? React with 👍 / 👎.
|
• 向工作流添加 set -x（Bash 脚本）以调试。
• 添加条件性处理 || exit 0 看是否能继续运行。
取得 iOS 版 Outlook<https://aka.ms/o0ukef>
________________________________
寄件者: chatgpt-codex-connector[bot] ***@***.***>
寄件日期: Sunday, November 16, 2025 11:24:47 AM
收件者: vercel/next.js ***@***.***>
副本: Mr.liou ***@***.***>; Author ***@***.***>
主旨: Re: [vercel/next.js] Next.js新分支 (PR #86174)
@chatgpt-codex-connector[bot] commented on this pull request.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo<http://chatgpt.com/codex/settings/general>. Reviews are triggered when you
* Open a pull request for review
* Mark a draft as ready
* Comment ***@***.***<https://github.com/codex> review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting ***@***.***<https://github.com/codex> address that feedback".
________________________________
In .github/workflows/webpack.yml<#86174 (comment)>:
+ - name: Build
+ run: |
+ npm install
+ npx webpack
[P1 Badge]<https://camo.githubusercontent.com/c595229c0ecb6ee85b9c7804144d495f131a495ec87091fea2b262d954c9a92d/68747470733a2f2f696d672e736869656c64732e696f2f62616467652f50312d6f72616e67653f7374796c653d666c6174> Update CI job to use valid build step
The new workflow runs npm install followed by npx webpack, but this repository is configured for pnpm workspaces and does not include a root-level webpack entry/config. As written the job will consistently fail on every push/PR to canary because webpack cannot find a project to build (and npm will also ignore the existing pnpm lockfile), so the workflow never succeeds.
Useful? React with 👍 / 👎.
—
Reply to this email directly, view it on GitHub<#86174 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BT3V3IGELGOG7O64YC4WZY3347U77AVCNFSM6AAAAACMHLBW2GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTINRZGI2TANJRGA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Co-authored-by: Copilot <[email protected]>
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| - name: Build | ||
| run: | | ||
| pnpm install | ||
| npx webpack |
There was a problem hiding this comment.
The direct npx webpack command may fail since it requires webpack to be installed and properly configured. Next.js projects typically use their own build system through commands like pnpm build, which would leverage the project's existing configuration. Consider replacing this with the appropriate Next.js build command to ensure compatibility with the project's build pipeline.
| npx webpack | |
| pnpm build |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Build | ||
| run: | | ||
| pnpm install | ||
| npx webpack |
There was a problem hiding this comment.
The workflow now runs npx webpack after a root pnpm install, but this repo is a pnpm/turbo monorepo without a root webpack dependency or config. On every push/PR to canary the job will fail because npx cannot find a webpack binary or project to build, so the workflow never succeeds.
Useful? React with 👍 / 👎.
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| - name: Build | ||
| run: | | ||
| pnpm install | ||
| npx webpack |
There was a problem hiding this comment.
| npx webpack | |
| pnpm run test-webpack |
The workflow will fail because npx webpack is run without any configuration or entry point. Webpack won't know what to bundle and will error out.
View Details
Analysis
Webpack workflow fails with missing configuration and entry point
What fails: The GitHub Actions workflow in .github/workflows/webpack.yml executes npx webpack without any configuration file or entry point, causing the build to fail with "Module not found: Error: Can't resolve './src'"
How to reproduce:
# Clone the repo and run the workflow steps:
pnpm install
npx webpackResult:
ERROR in main
Module not found: Error: Can't resolve './src' in '/path/to/repo'
using description file: /path/to/repo/package.json (relative path: .)
using description file: /path/to/repo/package.json (relative path: ./src)
no extension
/path/to/repo/src doesn't exist
.js
/path/to/repo/src.js doesn't exist
.json
/path/to/repo/src.json doesn't exist
.wasm
/path/to/repo/src.wasm doesn't exist
as directory
/path/to/repo/src doesn't exist
webpack 5.98.0 compiled with 1 error and 1 warning in 38 ms
Expected: The workflow should successfully test webpack functionality using the existing test suite, not fail with missing module resolution.
Fix: Changed the workflow to run pnpm run test-webpack which is the appropriate webpack test command already defined in package.json. This aligns with the workflow's purpose of validating webpack compatibility while using actual project test infrastructure rather than attempting to bundle a non-existent entry point.
1 participant
No description provided.