-
Notifications
You must be signed in to change notification settings - Fork 31.1k
[backport] feat(next/image): add lru disk cache and images.maximumDiskCacheSize
#91660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| import { promises } from 'fs' | ||
| import { LRUCache } from './lru-cache' | ||
|
|
||
| /** | ||
| * Module-level LRU singleton for disk cache eviction. | ||
| * Initialized once on first `set()`, shared across all consumers. | ||
| * Once resolved, the promise stays resolved — subsequent calls just await the cached result. | ||
| */ | ||
| let _diskLRUPromise: Promise<LRUCache<number>> | null = null | ||
|
|
||
| /** | ||
| * Initialize or return the module-level LRU for disk cache eviction. | ||
| * Concurrent calls are deduplicated via the shared promise. | ||
| * | ||
| * @param cacheDir - The directory where cached files are stored | ||
| * @param maxDiskSize - Maximum disk cache size in bytes | ||
| * @param readEntries - Callback to scan existing cache entries (format-agnostic) | ||
| */ | ||
| export async function getOrInitDiskLRU( | ||
| cacheDir: string, | ||
| maxDiskSize: number | undefined, | ||
| readEntries: ( | ||
| cacheDir: string | ||
| ) => Promise<Array<{ key: string; size: number; expireAt: number }>>, | ||
| evictEntry: (cacheDir: string, cacheKey: string) => Promise<void> | ||
| ): Promise<LRUCache<number>> { | ||
| if (!_diskLRUPromise) { | ||
| _diskLRUPromise = (async () => { | ||
| let maxSize = maxDiskSize | ||
| if (typeof maxSize === 'undefined') { | ||
| // Ensure cacheDir exists before checking disk space | ||
| await promises.mkdir(cacheDir, { recursive: true }) | ||
| // Since config was not provided, default to 50% of available disk space | ||
| const { bavail, bsize } = await promises.statfs(cacheDir) | ||
| maxSize = Math.floor((bavail * bsize) / 2) | ||
| } | ||
|
|
||
| const lru = new LRUCache<number>( | ||
| maxSize, | ||
| (size) => size, | ||
| (cacheKey) => evictEntry(cacheDir, cacheKey) | ||
| ) | ||
|
|
||
| const entries = await readEntries(cacheDir) | ||
| for (const entry of entries) { | ||
| lru.set(entry.key, entry.size) | ||
| } | ||
|
|
||
| return lru | ||
| })() | ||
| } | ||
| return _diskLRUPromise | ||
| } | ||
|
|
||
| /** | ||
| * Reset the module-level LRU singleton. Exported for testing only. | ||
| */ | ||
| export function resetDiskLRU(): void { | ||
| _diskLRUPromise = null | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.