fix: Correctly position font baseline and line-height #599
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes logic how baseline and line-height are calculated, to match what browsers do and
tools like Figma.
This is especially noticeable on font IBM Plex Sans due to how its metrics are set up. It was less noticeable on Inter, because previous calculations somehow arrived at almost correct numbers.
Implementation notes:
useOS2Table
is removed, because it’s not what browsers/Figma seem to be usingBefore:
After:
Background blue/orange text is a static PNG rendered with Figma, black text is rendered with Satori.
Should solve #577
References: https://iamvdo.me/en/blog/css-font-metrics-line-height-and-vertical-align
And https://www.figma.com/blog/line-height-changes/:
Background image (if needed):
https://github.com/vercel/satori/assets/285292/3c8d6a75-cdca-4774-b285-7bd64bae51ee