Yarn test fails due to flow error #244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going through the guide and I got a flow error running `yarn test`. See: verekia#221 The solution is to add: ``` [ignore] .*/node_modules/eslint-plugin-jsx-a11y/* ``` I propose to add this to the guide so others won't have this issue.
Open
|
Hi. Just wanted to report this issue myself. I encountered the same problem while following along. After some trial and error with the ignore pattern I eventually arrived at the same result. correction: I used the string: +1 for including it in the (very helpfull :) ) guide. |
|
@verekia can you review and merge this :) |
|
This is not an issue anymore with the recent versions of these packages, so we should probably discard the PR :) The whole tutorial needs a major update though. |
|
@verekia Okay closes this PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: This should no longer be an issue with the latest version of these packages, but if you have this problem here is the fix.
Going through the guide and I got a flow error running
yarn testat the part where one is required to add flow. See:#221
The solution is to add the following to your
.flowconfig:I propose to add this to the guide so others won't have this issue. Like these people: #237 and #221