Skip to content

Add --place_freq command line option #3204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

soheilshahrouz
Copy link
Contributor

Adds a new command line option to do placement for each channel width trial when searching for minimum channel width.

@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool docs Documentation lang-cpp C/C++ code labels Jul 21, 2025
Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Note from you to you: there is a bug fix you need to cherry-pick.
Should add a test that this option works on a trivial circuit.

@@ -375,23 +375,23 @@ constexpr int NUM_PL_MOVE_TYPES = 7;
constexpr int NUM_PL_NONTIMING_MOVE_TYPES = 3;

/* Timing data structures end */

// Annealing schedule
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could expand this comment. AUTO_SCHED: computes initial temperature, exit criterion and temperature update rate from statistics computing during the anneal.
USER_SCHED: the user has specified explicit numbers for the key annealing schedule parameters

PLACE_NEVER,
PLACE_ONCE,
PLACE_ALWAYS
enum class e_place_freq {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put a comment on this (doxygen)

@@ -52,6 +51,10 @@ void try_place(const Netlist<>& net_list,
// Initialize the variables in the placement context.
mutable_placement.init_placement_context(placer_opts, directs);

if (mutable_floorplanning.cluster_constraints.empty()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment why this only needs to be loaded once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation lang-cpp C/C++ code VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants