[bug fix] analytical place with graphics no longer segfault #3273
+31
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated the size of some graphics resources after ap
github-actions
bot
added
VPR
| #ifndef NO_GRAPHICS | ||
| // update graphic resources incase of clustering changes | ||
| if (get_draw_state_vars()) { | ||
| get_draw_state_vars()->refresh_graphic_resources_after_cluster_change(); |
There was a problem hiding this comment.
I do not think this bit of code belongs in this function. I recommend moving it somewhere else. Perhaps even into its own function. Post-place sync is not doing things related to drawing directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analytical placement update clustering global context later compared to original placement, but the graphic resources are initialized earlier in vpr flow. This causes a segmentation fault when enabling both display on and analytical place.
This PR fixes the issue.
Description
Resized graphic resources (block_color and net_color) in post_place_sync().
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: