Skip to content

Conversation

haydar-c
Copy link
Contributor

The updates in this PR are:

  • Added early validation of breakpoint expressions when the user sets them. Invalid expressions are now rejected immediately with an “Invalid Expression” message, preventing crashes later.
  • Fixed router iteration breakpoints: previously, when a router_iter condition was met, the debugger stopped on every net in that iteration. Now, it stops once per router iteration, and will only stop again when the condition is met in a future iteration.
  • Fixed a typo in the breakpoint pop-up message.

Related Issue
#3284

@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool lang-cpp C/C++ code labels Sep 29, 2025
Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume the user gets a message of some sort if he/she types in an invalid expression -- is that correct?

@haydar-c
Copy link
Contributor Author

Yes, exactly. When the user tries to set an invalid expression, we run an early validity check, and if it fails, a pop-up window is shown with the message “Invalid expression.” This prevents the expression from being added and avoids a crash later on.

image

@vaughnbetz
Copy link
Contributor

Thanks!

@vaughnbetz vaughnbetz merged commit 7b55b70 into master Sep 29, 2025
30 checks passed
@vaughnbetz vaughnbetz deleted the breakpoint_updates_PnR branch September 29, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-cpp C/C++ code VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants