Fix issues with resolve() and improve test coverage #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quarz0
requested review from
AlexJSully,
VickSuresh,
alexlaurinmath,
bitwizeshift and
jonhayesverily
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve() should not require the Reference.type field to be specified
This PR also adds proper handling for fragment and uri references, also skips empty strings from being passed to the resolver.
Also introduced a SimpleResolver to improve the test coverage - current tests only relied on HappyResolver which just returns without checking any references. If we remove the references from the current tests they'd still pass