retain order in responses to cross-slot requests #540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, requests that target multiple cluster nodes are rejected. However, if there's a reducer registered for the command, such requests are allowed and are sent to all required cluster nodes. The responses are then combined using the reducer. Until this commit, there was no guarantee on ordering of the responses, which makes the `MGET` command relatively useless in the cross-slot scenario. This commit makes sure that ordering of responses is identical to ordering of requests, making cross-slot `MGET` useful. (There's no other command for which we register a reducer and ordering matters.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, requests that target multiple cluster nodes are rejected. However, if there's a reducer registered for the command, such requests are allowed and are sent to all required cluster nodes. The responses are then combined using the reducer.
Until this commit, there was no guarantee on ordering of the responses, which makes the
MGETcommand relatively useless in the cross-slot scenario. This commit makes sure that ordering of responses is identical to ordering of requests, making cross-slotMGETuseful. (There's no other command for which we register a reducer and ordering matters.)Fixes #537