Skip to content

feat: [MOB-121] Add LinkDomain to ActionCodeSettings #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

graeme-verticalscope
Copy link

About this change

Add the LinkDomain field to the ActionCodeSettings struct, this new field enables migrating off of firebase dynamic links, which is deprecated and will be unsupported soon.

See issue firebase#681, and original PR firebase#682

Unit test is updated to check that linkDomain is set correctly in the action code settings map.

What should reviewers focus on

I've created a branch vs-patch-1-v4-15-2, to be the target branch for this change. I don't want to update the master branch because that will muddy our ability to keep the master branch in sync with the original repository.

Plan for maintaining our fork is:

  • Sync master, and ensure the latest commit on master matches the commit id of the latest release tag in the original repository
  • Make a patch branch off of the master branch, named something like <patch-name>-<release-version>
  • Apply our patch commit on top of the branch
  • Create a release tag like <release-version>-vspatch.1 (see go module versioning)
  • Use the replace feature in go.mod to switch fl-core to our patched release version (see using forked package import in go)

@graeme-verticalscope graeme-verticalscope merged commit 0dfb778 into vs-patch-1-v4-15-2 Apr 16, 2025
@graeme-verticalscope
Copy link
Author

For quick reference, here's how I created the tag. Run this on the the latest version of the patch branch to create your patch tag:

git tag -a v4.15.2-vspatch.1 -m "VerticalScope patch 1 of firebase-admin-go v4.15.2"
git push origin v4.15.2-vspatch.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants