Skip to content

Conversation

@GKotsifos
Copy link

Fixes Error message on using test vendors out of test scope #120

Description of changes in release / Impact of release:

Adds proper detection of test-only modules (unittest, asserts). When these modules are imported outside test mode, Larky now throws a clear and informative error instead of a generic exception.

Documentation

(insert text here)

Risks of this release

Is this a breaking change?

  • Yes
  • No

If you answered Yes then describe why is it so

(insert text here if applicable)

Is there a way to disable the change?

  • Use previous release
  • Use a feature flag
  • No

Additional details go here

(insert text here if applicable)

@mahmoudimus
Copy link
Collaborator

Hmm your pull request description says, "throws a clear and informative error instead of a generic exception" -- is there a generic exception being thrown right now? What test do we have that can confirm this? What test do we have that can confirm the scenario where this exception is thrown as well?

@GKotsifos
Copy link
Author

Hmm your pull request description says, "throws a clear and informative error instead of a generic exception" -- is there a generic exception being thrown right now? What test do we have that can confirm this? What test do we have that can confirm the scenario where this exception is thrown as well?

I want to make sure I fully understand what you are asking for. We already have .star tests that import unittest and asserts. Are you looking for new Junit test that explicitly loads a test-only module in a non-test context and asserts on the exact error message or something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error message on using test vendors out of test scope

3 participants